superset icon indicating copy to clipboard operation
superset copied to clipboard

docs: Update STANDARD_ROLES.md, delete 7 permissions "RowLevelSecurityFiltersModelView"

Open xavier-GitHub76 opened this issue 6 months ago • 5 comments

Delete 7 permissions "RowLevelSecurityFiltersModelView"

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue: Fixes https://github.com/apache/superset/issues/32205
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

xavier-GitHub76 avatar Jun 03 '25 09:06 xavier-GitHub76

To fix : https://github.com/apache/superset/issues/32205

xavier-GitHub76 avatar Jun 03 '25 09:06 xavier-GitHub76

Seems about right to me, but should we also remove this while we're at it?

rusackas avatar Jun 09 '25 22:06 rusackas

I went ahead and removed RowLevelSecurityFiltersModelView from the security manager file as well, since it appears obsolete.

rusackas avatar Jun 12 '25 22:06 rusackas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.96%. Comparing base (76d897e) to head (0a9007b). Report is 1986 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #33670       +/-   ##
===========================================
+ Coverage   60.48%   72.96%   +12.47%     
===========================================
  Files        1931      558     -1373     
  Lines       76236    40292    -35944     
  Branches     8568     4223     -4345     
===========================================
- Hits        46114    29398    -16716     
+ Misses      28017     9803    -18214     
+ Partials     2105     1091     -1014     
Flag Coverage Δ
hive 47.22% <ø> (-1.94%) :arrow_down:
javascript ?
mysql 71.94% <ø> (?)
postgres 72.01% <ø> (?)
presto 50.97% <ø> (-2.83%) :arrow_down:
python 72.92% <ø> (+9.41%) :arrow_up:
sqlite 71.52% <ø> (?)
unit 100.00% <ø> (+42.36%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 12 '25 23:06 codecov[bot]

Maybe @geido or @msyavuz can make sure i'm not being dumb in removing that... pretty sure it's no longer used, but would love a second pair of eyes ;)

rusackas avatar Jun 13 '25 21:06 rusackas