superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: %s for plural (Added to %s dashboard) to avoid poedit alert

Open xavier-GitHub76 opened this issue 8 months ago • 1 comments

This PR fix #32674

SUMMARY

Update to avoid alert in poedit, the msgid use %s for singular and plural.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before : image

After : image

TESTING INSTRUCTIONS

Create a graph and add it to a dashboard The tag mention : "Added to 1 dashboard" image

xavier-GitHub76 avatar Mar 27 '25 12:03 xavier-GitHub76

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 83.41%. Comparing base (76d897e) to head (248b9f8). :warning: Report is 3184 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32881       +/-   ##
===========================================
+ Coverage   60.48%   83.41%   +22.92%     
===========================================
  Files        1931      549     -1382     
  Lines       76236    39486    -36750     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32938    -13176     
+ Misses      28017     6548    -21469     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.39% <ø> (-0.76%) :arrow_down:
javascript ?
mysql 75.63% <ø> (?)
postgres 75.70% <ø> (?)
presto 52.88% <ø> (-0.92%) :arrow_down:
python 83.41% <ø> (+19.91%) :arrow_up:
sqlite 75.20% <ø> (?)
unit 61.39% <ø> (+3.76%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 27 '25 12:03 codecov[bot]

Hi @xavier-GitHub76 👋

This PR has merge conflicts and is 1688 commits behind master. Converting to draft until resolved.

When you have time, please rebase on master to resolve the conflicts. The PR already has approval from @mistercrunch, so once conflicts are resolved it should be ready to merge.

If you're no longer able to work on this, let us know and we can close or have someone else pick it up.

Thanks for your i18n contribution! 🙏

rusackas avatar Dec 11 '25 22:12 rusackas