superset icon indicating copy to clipboard operation
superset copied to clipboard

List Roles: Action icon not displayed

Open praveer38 opened this issue 1 year ago • 1 comments

Screenshot

image

Description

On the List Roles page, there seems to be an icon in the “Actions” button that is not being displayed correctly.

praveer38 avatar Oct 17 '24 10:10 praveer38

The issue with the icon not being displayed correctly in the "Actions" button on the List Roles page might be related to the CSS styles applied to the button. The StyledActions and ActionWrapper components define styles that could affect the icon's visibility. Specifically, the svg and i elements have a margin-right of 8px, and on hover, the path within these elements changes its fill color to the theme's primary base color. Additionally, the text color is set to the theme's grayscale base color, which might cause visibility issues if the theme's colors are similar to the background [1].

To address this, you might want to check the theme's color settings and ensure they provide enough contrast for the icons to be visible. Additionally, verify that the icon libraries @react-icons/all-files and @ant-design/icons are correctly installed and configured, as these are used for rendering icons in Apache Superset [2][3][4].

To continue talking to Dosu, mention @dosu.

dosubot[bot] avatar Oct 17 '24 10:10 dosubot[bot]

Valid, but this view needs to be converted from a FAB view (Python/Jinja template) to a React view. This isn't likely to get prioritized, but we're happy to review a PR!

rusackas avatar Nov 08 '24 05:11 rusackas

Hey @rusackas , would love to work on this bug

samarsrivastav avatar Nov 10 '24 05:11 samarsrivastav

Hey @rusackas , would love to work on this bug

Fantastic, go for it!

rusackas avatar Nov 12 '24 03:11 rusackas

@samarsrivastav are you still working on this? Don't worry, I'm just checking over the project's issues :D

hainenber avatar Feb 18 '25 05:02 hainenber

No @hainenber , i am not working on this issue now, I have got several issues regarding the cloning of the code in my local computer, still got no fix : /

samarsrivastav avatar Feb 18 '25 05:02 samarsrivastav

This view has been completely rewritten as a React view rather than a FAB view, so this issue should no longer be relevant. Thanks!

rusackas avatar May 29 '25 22:05 rusackas