chore(Dashboard): Let Dashboard Header load progressively
SUMMARY
This PR is part of an ongoing effort to let the Dashboard load progressively as the data becomes available. The video below illustrates how the Header would look like while the dashboard information are not fully retrieved yet. The effect of this PR will become visible when other blocking parts of the Dashboard loading process will be unblocked.
AFTER
https://github.com/user-attachments/assets/6148ec2e-2a6b-4bd0-8b29-6b82e108687b
TESTING INSTRUCTIONS
- The Dashboard Header should load normally
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Thanks for the change! I think it would be nice to add more skeletons for loading as it's more unified and less distracting, so my proposal would be:
- keep title loading as it is
- change metadata spinner to skeleton
- not show star + pill before it's loaded if possible or change to skeleton
What do you think?
Thanks for the change! I think it would be nice to add more skeletons for loading as it's more unified and less distracting, so my proposal would be:
- keep title loading as it is
- change metadata spinner to skeleton
- not show star + pill before it's loaded if possible or change to skeleton
What do you think?
I think we might still want to show the star + pill as those will always be there? I am concerned about the UI pushing elements to the right as they appear on screen.
Thanks for the change! I think it would be nice to add more skeletons for loading as it's more unified and less distracting, so my proposal would be:
- keep title loading as it is
- change metadata spinner to skeleton
- not show star + pill before it's loaded if possible or change to skeleton
What do you think?
I think we might still want to show the star + pill as those will always be there? I am concerned about the UI pushing elements to the right as they appear on screen.
Yeah, that makes sense, we can keep it :)
/testenv up
@kgabryje Ephemeral environment spinning up at http://34.222.53.133:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.
Moving this back to draft while tackling Kasia's UI comments
Will this PR be merged in nearest future?
This hit my stale-draft radar... not sure if there's still hope of getting it through or if we should close it out :)
In React 18 onwards, <Suspense> can be used to do exactly this. We can return to this feature after React update goes through.
Hi @geido 👋
This draft PR has been open for about 14 months. Are you still planning to complete this dashboard header performance improvement?
If so, it will likely need a rebase on master given the time elapsed. If you're no longer working on this, please let us know and we can close it.
Thanks!
Closing this for now as this was some experimental effort. Due to the state of our redux store and highly interdependent components, this calls for a much larger refactor.