superset icon indicating copy to clipboard operation
superset copied to clipboard
verified publisher icon apache

feat(D3_FORMAT_OPTIONS): Add duration formatter with colon notation

Open gerbermichi opened this issue 1 year ago • 1 comments

SUMMARY

Introduces a new formatter, DURATION_COL, for durations presented in colon notation (e.g., 0:10.5).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

  1. Create a chart with a duration (in ms) column
  2. Change the number formatter to Duration in ms (10500 => 0:10.5)

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [x] Introduces new feature or API
  • [ ] Removes existing feature or API

gerbermichi avatar Oct 14 '24 08:10 gerbermichi

FYI: I opened a PR to bump pretty-ms to pull in a critical fix for colonNotation, as that's what we should be using here: #30599

villebro avatar Oct 14 '24 21:10 villebro