superset icon indicating copy to clipboard operation
superset copied to clipboard

chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG

Open nsivarajan opened this issue 1 year ago • 2 comments

SUMMARY

This PR follows up on https://github.com/apache/superset/pull/29912 and removes the deprecated GLOBAL_ASYNC_QUERIES_REDIS_CONFIG configuration in favor of the new GLOBAL_ASYNC_QUERIES_CACHE_BACKEND configuration. It is intended to be merged into version 5.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

nsivarajan avatar Sep 15 '24 06:09 nsivarajan

Codecov Report

:x: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 83.46%. Comparing base (dfb9af3) to head (df76251). :warning: Report is 855 commits behind head on master.

Files with missing lines Patch % Lines
superset/async_events/async_query_manager.py 75.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30284       +/-   ##
===========================================
+ Coverage        0   83.46%   +83.46%     
===========================================
  Files           0      546      +546     
  Lines           0    39284    +39284     
===========================================
+ Hits            0    32787    +32787     
- Misses          0     6497     +6497     
Flag Coverage Δ
hive 48.81% <75.00%> (?)
mysql 75.99% <75.00%> (?)
postgres 76.05% <75.00%> (?)
presto 53.30% <75.00%> (?)
python 83.46% <75.00%> (?)
sqlite 75.52% <75.00%> (?)
unit 61.08% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 15 '24 06:09 codecov[bot]

I think @villebro has the most context here, so I'll request his review, and re-start our flaky E2E test while I'm at it.

rusackas avatar Sep 16 '24 16:09 rusackas

@nsivarajan can you rebase this PR? The breaking change window for 5.0 is open, so we can now merge this.

villebro avatar Jan 14 '25 17:01 villebro

@villebro Sure - I'll update in two days

nsivarajan avatar Jan 15 '25 09:01 nsivarajan

Hi @villebro, I've pushed the recent commits to the PR. Could you please assist with the review when you have time?

nsivarajan avatar Jan 16 '25 02:01 nsivarajan

@nsivarajan UPDATING.md entry looks good, but it seems the rebase was unsuccessful, as there's been some unrelated changes. Can you fix the conflict and make sure only your change is present in the diff?

villebro avatar Jan 18 '25 18:01 villebro

Thanks, @villebro, for all the guidance. As always, it's been very helpful!

nsivarajan avatar Jan 18 '25 18:01 nsivarajan

Thanks, @villebro, for all the guidance. As always, it's been very helpful!

@nsivarajan it was my pleasure, thanks for taking care of this important breaking change for 5.0! I'm rerunning some flaky CI tests, will merge once CI is green.

villebro avatar Jan 18 '25 18:01 villebro

The E2E failure is unrelated to this PR and will be fixed by https://github.com/apache/superset/pull/31933.

michael-s-molina avatar Jan 21 '25 14:01 michael-s-molina

Close/reopen to restart CI after fixed flaky test.

villebro avatar Jan 21 '25 17:01 villebro

@nsivarajan can you rebase the PR to see if the flaky test now passes? Closing/reopening didn't resolve the issue.

villebro avatar Jan 21 '25 17:01 villebro

@villebro - Thanks again, finally all green! please help to merge.

nsivarajan avatar Jan 22 '25 04:01 nsivarajan

Finally!

villebro avatar Jan 22 '25 04:01 villebro