feat: Adding details to Dataset/Database deletion modals
SUMMARY
This PR lists all dashboards and charts affected by the (potential) deletion of a dataset/database.
The links to these assets all open in a single (named) new window.
It also does a little cleanup along the way:
- modal is now always centered (so it scrolls sensibly)
- the "delete" button is now the "Delete" button
- Highlights the name of the dataset/database that's getting deleted... this seems important.
- Updates the .pot file since some strings are getting tweaked in there.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before (Dataset deletion):
After (Dataset deletion):
Before (Database deletion)
After (Database deletion):
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
:x: @Jarred-Sumner, your commit 5896c71daaf9c70354729de1ea91172a2801b8f6 has 11 failures in #2542:
test/js/bun/http/serve-body-leak.test.ts - 2 failing on 🪟 x64-baselinetest/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64test/cli/watch/watch.test.ts - timeout on 🪟 x64-baselinetest/cli/install/bun-run.test.ts - 1 failing on 🪟 x64-baselinetest/js/node/process/process.test.js - 2 failing on 🐧 12 aarch64test/js/bun/test/mock/mock-module.test.ts - segmentation fault on 🪟 x64test/js/bun/test/mock/mock-module.test.ts - segmentation fault on 🪟 x64-baselinetest/cli/hot/watch.test.ts - 1 failing on 🪟 x64test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baselinetest/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64test/cli/hot/hot.test.ts - 2 failing on 🪟 x64test/cli/hot/hot.test.ts - 3 failing on 🪟 x64-baselinetest/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 14 aarch64test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baselinetest/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 14 aarch64
what about serving static directory?
maybe smth like '/assets/*': serve.static(pathToDir)?
also cold start may be useful
'/on-demand-endpoint': () => someSlowFunction()
function is called once and return value served as static