superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: Adding details to Dataset/Database deletion modals

Open rusackas opened this issue 1 year ago • 2 comments

SUMMARY

This PR lists all dashboards and charts affected by the (potential) deletion of a dataset/database.

The links to these assets all open in a single (named) new window.

It also does a little cleanup along the way:

  • modal is now always centered (so it scrolls sensibly)
  • the "delete" button is now the "Delete" button
  • Highlights the name of the dataset/database that's getting deleted... this seems important.
  • Updates the .pot file since some strings are getting tweaked in there.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before (Dataset deletion): image

After (Dataset deletion): image

Before (Database deletion) Screenshot 2024-08-26 at 10 11 52 AM

After (Database deletion): image image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rusackas avatar Aug 26 '24 18:08 rusackas

what about serving static directory? maybe smth like '/assets/*': serve.static(pathToDir)?

also cold start may be useful '/on-demand-endpoint': () => someSlowFunction() function is called once and return value served as static

ghost avatar Aug 26 '24 12:08 ghost