superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(sqllab): Replace FilterableTable by AgGrid Table

Open justinpark opened this issue 1 year ago • 5 comments

SUMMARY

Following up #27645, This commit includes the migration of the component used for SQLLab results from the ant-table component to the ag-grid component. During this process, the existing logic(getWidthsForColumns) that measured column size to adjust the width was removed because it was not only performance-intensive but also unnecessary, as the resizable column option in ag-grid allows users to adjust the width as needed. Additionally, other property options were modified to ensure compatibility with ag-grid. Moreover, a column menu feature was added, enabling users to pin specific columns and apply filters.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2024-08-09 at 7 33 03 AM

After:

Screenshot 2024-08-20 at 11 46 53 AM

Header menu (Actions):

Image

TESTING INSTRUCTIONS

Go to SQL Lab and run a query to explore the data

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [x] Introduces new feature or API
  • [ ] Removes existing feature or API

justinpark avatar Aug 09 '24 02:08 justinpark

@justinpark this looks great! I think I might have asked this question before, so apologies if I did, but for how long custom table settings are kept - just for session and just for this specific query?

kasiazjc avatar Aug 12 '24 12:08 kasiazjc

/testenv up

yousoph avatar Aug 12 '24 18:08 yousoph

@yousoph Ephemeral environment spinning up at http://35.160.157.54:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Aug 12 '24 18:08 github-actions[bot]

how long custom table settings are kept - just for session and just for this specific query?

You're right. This will only apply to the current query in the current session. I considered saving it, but I thought it might be better not to, as revisiting the query later when the memory has faded could cause confusion with different items being displayed in the query results.

justinpark avatar Aug 13 '24 11:08 justinpark

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.46%. Comparing base (76d897e) to head (3d526f3). Report is 1358 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29900       +/-   ##
===========================================
+ Coverage   60.48%   83.46%   +22.97%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39276    -36960     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32783    -13331     
+ Misses      28017     6493    -21524     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.77% <ø> (-0.40%) :arrow_down:
javascript ?
mysql 75.99% <ø> (?)
postgres 76.05% <ø> (?)
presto 53.26% <ø> (-0.54%) :arrow_down:
python 83.46% <ø> (+19.98%) :arrow_up:
sqlite 75.53% <ø> (?)
unit 61.04% <ø> (+3.41%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 10:08 codecov[bot]

when is the release target date and release version ?

Hokwang avatar Nov 11 '24 04:11 Hokwang

when is the release target date and release version ?

@Hokwang this will most likely be released in 5.0 around April 2025.

eschutho avatar Dec 11 '24 21:12 eschutho

/testenv up

eschutho avatar Dec 11 '24 21:12 eschutho

@eschutho Processing your ephemeral environment request here.

github-actions[bot] avatar Dec 11 '24 21:12 github-actions[bot]

@eschutho Ephemeral environment spinning up at http://44.243.18.92:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Dec 11 '24 22:12 github-actions[bot]

@eschutho Thanks for your comment, but I can't find at 5.0 project. Please add this item.

Hokwang avatar Dec 17 '24 07:12 Hokwang

@eschutho Thanks for your comment, but I can't find at 5.0 project. Please add this item.

@Hokwang The 5.0 project board contain only breaking changes that need consensus which is not the case for this PR. That does not mean that only what's in the board will be released. On February 3rd, we'll cut from master branch and all PRs merged by then will be included in the release. Check our Release Process for more details.

michael-s-molina avatar Dec 17 '24 13:12 michael-s-molina

@michael-s-molina Oh, I see. Thanks for more detail information.

Hokwang avatar Dec 18 '24 00:12 Hokwang

/testenv up

justinpark avatar Jan 17 '25 17:01 justinpark

@justinpark Processing your ephemeral environment request here.

github-actions[bot] avatar Jan 17 '25 17:01 github-actions[bot]

@justinpark Ephemeral environment spinning up at http://52.33.205.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Jan 17 '25 18:01 github-actions[bot]