chore(AntD5): touchup on component imports/exports, theming ListViewCard
SUMMARY
This component simplifies some component imports/exports, making it so that ONLY the Superset components use the base AntD components. We should be consolidating on Superset-wrapped AntD components whenever/wherever possible and relevant.
Also, this styles the ListViewCard to inherit the AntD theme "tokens" for the "Card" and adds a pattern to override them when necessary (rather than getting into granular CSS, which adds complexity and might cause future upgrade problems).
It also adds an AntD theme provider in Storybook, so all components will automatically be handed the theme.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Tested these components in Storybook and compared to the public storybook on master..
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@dosu-bot any idea why my tests are failing? I get this kind of error several times:
FAIL src/pages/DashboardList/DashboardList.test.jsx
● Test suite failed to run
Domain `undefined` was not found.
87 |
[88](https://github.com/apache/superset/actions/runs/10097447336/job/27922326057?pr=29545#step:13:89) | translate(input: string, ...args: unknown[]): string {
> [89](https://github.com/apache/superset/actions/runs/10097447336/job/27922326057?pr=29545#step:13:90) | return this.i18n.translate(input).fetch(...args);
| ^
[90](https://github.com/apache/superset/actions/runs/10097447336/job/27922326057?pr=29545#step:13:91) | }
91 |
92 | translateWithNumber(key: string, ...args: unknown[]): string {
at Jed.dcnpgettext (node_modules/jed/jed.js:249:15)
at Chain.fetch (node_modules/jed/jed.js:148:20)
at Translator.fetch [as translate] (packages/superset-ui-core/src/translation/Translator.ts:89:39)
at translate (packages/superset-ui-core/src/translation/TranslatorSingleton.ts:67:24)
at Object.<anonymous> (src/pages/DashboardList/index.tsx:73:35)
at Object.require (src/pages/DashboardList/DashboardList.test.jsx:34:1)