fix(plugin/country/map): rectify naming for some Vietnamese provinces

[hainenber]

fix(plugin/country/map): rectify naming for some Vietnamese provinces

SUMMARY

Some Vietnamese provinces are incorrectly named without diacritics and "Hồ Chí Minh City" should be named natively as "Thành phố Hồ Chí Minh". This PR is to remediate such issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• [ ] Has associated issue:
• [ ] Required feature flags:
• [ ] Changes UI
• [ ] Includes DB Migration (follow approval process in SIP-59)
  • [ ] Migration is atomic, supports rollback & is backwards-compatible
  • [ ] Confirm DB migration upgrade and downgrade tested
  • [ ] Runtime estimates and downtime expectations provided
• [ ] Introduces new feature or API
• [ ] Removes existing feature or API

[rusackas]

Hi! This is much appreciated, but we need to make edits in the Jupyter notebook that generates these files. If we only edit the GeoJson files, they will be overwritten the next time someone runs the notebook. Hopefully this blog post explains it, but if not I'm happy to improve it. https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/

[hainenber]

Awesome! Thanks for the lead. I'll be checking the referred blog 😄

[hainenber]

I've updated the Notebook! No idea why other countries's geojson has a new name attribute though :D

[hainenber]

oh I saw you were having the side effects also :D

https://github.com/apache/superset/pull/29627

[rusackas]

Heya! Yep... and that PR of mine just merged. If you don't mind rebasing (which might have some notebook changes to sort out) I think this'll be easy to review/merge after that.

[hainenber]

Rebased and now pending for review/approval :D

[hainenber]

hi @rusackas, is this PR still eligible? A bit rusty in the shed now :D

[rusackas]

Sorry I missed this! Yes, it's fine! Will merge as soon as it turns green again.