superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: add support to NOT LIKE operator

Open dacopan opened this issue 1 year ago • 1 comments

SUMMARY

Change get_sqla_query method of helpers.py to support NOT_LIKE operator

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [x] Introduces new feature or API
  • [ ] Removes existing feature or API

dacopan avatar Jun 26 '24 23:06 dacopan

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.32%. Comparing base (76d897e) to head (1cd177f). Report is 966 commits behind head on master.

Files with missing lines Patch % Lines
superset/models/helpers.py 25.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29384      +/-   ##
==========================================
+ Coverage   60.48%   70.32%   +9.83%     
==========================================
  Files        1931     1967      +36     
  Lines       76236    78342    +2106     
  Branches     8568     8966     +398     
==========================================
+ Hits        46114    55095    +8981     
+ Misses      28017    21049    -6968     
- Partials     2105     2198      +93     
Flag Coverage Δ
hive 49.04% <20.00%> (-0.12%) :arrow_down:
javascript 58.05% <ø> (+0.34%) :arrow_up:
mysql 76.99% <40.00%> (?)
postgres 77.10% <40.00%> (?)
presto 53.66% <20.00%> (-0.14%) :arrow_down:
python 83.69% <40.00%> (+20.20%) :arrow_up:
sqlite 76.57% <40.00%> (?)
unit 59.63% <20.00%> (+2.00%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 27 '24 00:06 codecov[bot]

Running CI 🤞

rusackas avatar Jul 03 '24 16:07 rusackas

I don't understand why fail front end test, my changes not affect to failed tests

dacopan avatar Jul 03 '24 17:07 dacopan

Re-running that one... it might just be flaky, I've seen this one fail randomly before.

rusackas avatar Jul 03 '24 17:07 rusackas

I no have option to re-run

dacopan avatar Jul 03 '24 18:07 dacopan

@rusackas please your help with the pipeline, in my local server all test run OK, I don't understand why fail in test that files that not changed from master

dacopan avatar Jul 07 '24 22:07 dacopan

Running it again... ping me if it flakes out :)

rusackas avatar Jul 08 '24 17:07 rusackas