superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: add connector for CouchbaseDB

Open ayush33143314 opened this issue 1 year ago • 5 comments

SUMMARY

Add support for couchbase db. https://www.couchbase.com/products/analytics/

TESTING INSTRUCTIONS

mannual Testing

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

ayush33143314 avatar Jun 12 '24 08:06 ayush33143314

Codecov Report

Attention: Patch coverage is 60.82474% with 38 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (76d897e) to head (9c8016a). Report is 966 commits behind head on master.

Files with missing lines Patch % Lines
superset/db_engine_specs/couchbasedb.py 60.82% 38 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29225      +/-   ##
==========================================
+ Coverage   60.48%   70.34%   +9.85%     
==========================================
  Files        1931     1970      +39     
  Lines       76236    78585    +2349     
  Branches     8568     8973     +405     
==========================================
+ Hits        46114    55279    +9165     
+ Misses      28017    21108    -6909     
- Partials     2105     2198      +93     
Flag Coverage Δ
hive 49.12% <54.63%> (-0.05%) :arrow_down:
javascript 58.05% <ø> (+0.33%) :arrow_up:
mysql 77.00% <54.63%> (?)
postgres 77.08% <54.63%> (?)
presto 53.71% <54.63%> (-0.10%) :arrow_down:
python 83.65% <60.82%> (+20.16%) :arrow_up:
sqlite 76.57% <54.63%> (?)
unit 59.67% <60.82%> (+2.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 12 '24 15:06 codecov[bot]

Thanks @ayush33143314 for adding the engine. Would you also mind:

  • Adding unit/integration tests (where necessary)
  • Updating the various documentation which outlines which engines we support etc.

john-bodley avatar Jun 12 '24 18:06 john-bodley

Thank you for this! Would it also be possible to add a docs entry here?

rusackas avatar Jun 24 '24 17:06 rusackas

Thank you for this! Would it also be possible to add a docs entry here?

Hi , yes, I am preparing the doc, I will submit doc along with tests in next patchset. Sorry for this patch. It is still in progress.

ayush-couchbase avatar Jun 24 '24 17:06 ayush-couchbase

Ahh, ok, thanks! Feel free to add [WIP] to the title and/or convert it to a draft PR if you need a while to keep working on it, just so others don't assume it's ready for review like I did. Thanks again!

rusackas avatar Jun 24 '24 17:06 rusackas

@hughhhh @john-bodley Please review my latest patch, and guide me if I need to make any change. Thank you

ayush-couchbase avatar Jul 05 '24 19:07 ayush-couchbase

Looking forward to this PR being merged

huangang avatar Jul 09 '24 03:07 huangang

Feel free to add the logo, too! They can appear on the website and readme.

rusackas avatar Jul 09 '24 16:07 rusackas