superset icon indicating copy to clipboard operation
superset copied to clipboard

refactor: Upgrade Badge component to Ant Design 5

Open geido opened this issue 1 year ago • 0 comments

SUMMARY

This Proof of Concept (POC) aims to demonstrate the capability to upgrade Ant Design components to the latest version in isolation, facilitating incremental upgrades.

Two versions of Ant Design will be maintained until all components are upgraded to the latest version.

Please refer to the inline comments in this PR and the Superset Improvement Proposal https://github.com/apache/superset/issues/29268

This PR is dependent on PR https://github.com/apache/superset/pull/29328

BEFORE

340085271-92a84b90-7d3b-47cc-8895-fadaf673b3e4

340429169-6c6264ec-6780-48d9-bb40-8edab2ae2e92

AFTER

Note that the prop textColor has been removed as it was unused.

340085221-236370b1-69f9-46e4-97bf-37ce2842e06c

340429536-8910c99e-db52-428d-9a17-daece5d5e3ac

TESTING INSTRUCTIONS

  1. Verify the usage of the Badge throughout the application.
  2. Ensure no visual or behavioral changes have been introduced.

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

geido avatar Jun 09 '24 17:06 geido