superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: adds the ability to disallow SQL functions per engine

Open dpgaspar opened this issue 1 year ago • 1 comments

SUMMARY

Adds a new configuration key named DISALLOWED_SQL_FUNCTIONS that defines disallowed function per engine on SQL statements. These functions will be disallowed on SQLLab and Charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

dpgaspar avatar May 22 '24 13:05 dpgaspar

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (76d897e) to head (396a8e0). Report is 1094 commits behind head on master.

Files with missing lines Patch % Lines
superset/db_engine_specs/base.py 75.00% 1 Missing :warning:
superset/exceptions.py 66.66% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28639       +/-   ##
===========================================
+ Coverage   60.48%   83.43%   +22.94%     
===========================================
  Files        1931      523     -1408     
  Lines       76236    37605    -38631     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31377    -14737     
+ Misses      28017     6228    -21789     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.99% <28.57%> (-0.18%) :arrow_down:
javascript ?
postgres 77.22% <71.42%> (?)
presto 53.56% <71.42%> (-0.24%) :arrow_down:
python 83.43% <92.85%> (+19.95%) :arrow_up:
sqlite 76.68% <71.42%> (?)
unit 58.95% <92.85%> (+1.33%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 13:05 codecov[bot]