superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(engine): update databend engine spec for dialect version >=0.4.6

Open rad-pat opened this issue 1 year ago • 3 comments

SUMMARY

The Databend driver changed for later dialect versions and this requires different params on the connection string. This PR includes the latest revision of the databend dialect which itself contained a number of fixes and now includes validation via SQLAlchemy testing suite.

TESTING INSTRUCTIONS

Validate by testing against a Databend instance

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rad-pat avatar May 21 '24 14:05 rad-pat

@hantmac - as discussed, here is PR for updating superset with latest dialect.

rad-pat avatar May 21 '24 14:05 rad-pat

@hantmac it seems like you maybe added the the Databend engine spec and thus I was wondering whether you would mind reviewing the PR?

john-bodley avatar May 21 '24 17:05 john-bodley

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.00%. Comparing base (76d897e) to head (7027143). Report is 1468 commits behind head on master.

Files with missing lines Patch % Lines
superset/db_engine_specs/databend.py 22.22% 7 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28627       +/-   ##
===========================================
+ Coverage   60.48%   83.00%   +22.51%     
===========================================
  Files        1931      539     -1392     
  Lines       76236    39071    -37165     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32430    -13684     
+ Misses      28017     6641    -21376     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.83% <22.22%> (-0.33%) :arrow_down:
javascript ?
mysql 75.60% <22.22%> (?)
postgres 75.66% <22.22%> (?)
presto 53.35% <22.22%> (-0.45%) :arrow_down:
python 83.00% <22.22%> (+19.51%) :arrow_up:
sqlite 75.13% <22.22%> (?)
unit 61.04% <22.22%> (+3.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 13:05 codecov[bot]

@hantmac it seems like you maybe added the the Databend engine spec and thus I was wondering whether you would mind reviewing the PR?

Sorry for late response. I will review as soon as possible. Thanks!

hantmac avatar Jun 03 '24 09:06 hantmac

@betodealmeida , any chance of this progressing? Do you want me to rebase against master?

rad-pat avatar Sep 06 '24 11:09 rad-pat

/korbit-review

rusackas avatar Feb 20 '25 19:02 rusackas