superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: add Nightingale chart support for echarts pie chart

Open hexcafe opened this issue 1 year ago • 5 comments

SUMMARY

Add Nightingale Chart Support for Echarts Pie Chart

Echarts now supports Nightingale charts in pie charts, with two optional modes:

  1. radius: Uses the central angle to show the percentage of data and the radius to show data size.
  2. area: All sectors share the same central angle, with data size shown only through radiuses.

I have added a new option, 'ROSE TYPE,' to support this feature.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: image

After: image image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

hexcafe avatar May 20 '24 08:05 hexcafe

Pretty cool! Are you aware of any feature-parity issues that would prevent a migration from the legacy rose chart to this? I'm always excited to deprecate/remove a legacy plugin in favor of a newer option :)

Also, would you mind adding this to the React Storybook entry? We're making a renewed effort to capture as many variants as possible there (interactive or static).

rusackas avatar May 20 '24 18:05 rusackas

Pretty cool! Are you aware of any feature-parity issues that would prevent a migration from the legacy rose chart to this? I'm always excited to deprecate/remove a legacy plugin in favor of a newer option :)

@rusackas I checked and the legacy plugin has no additional feature that would prevent us from migrating.

Screenshot 2024-05-21 at 08 54 38 Screenshot 2024-05-21 at 08 54 49


I added a card to the 5.0 project board to remove the legacy version.

michael-s-molina avatar May 21 '24 11:05 michael-s-molina

@michael-s-molina Thanks! I have updated the metadata. Now, we can discover the chart by searching for "Nightingale". image

hexcafe avatar May 21 '24 13:05 hexcafe

@rusackas @michael-s-molina Should we upgrade to ECharts v5.5.0 soon? please take a look at #27341 , Thanks!

hexcafe avatar May 21 '24 13:05 hexcafe

Hi @michael-s-molina ,

Sorry for the delay. I have fixed the type errors. I hope this PR can be merged soon.

Thank you!

hexcafe avatar May 26 '24 08:05 hexcafe

/testenv up

rusackas avatar May 28 '24 17:05 rusackas

@rusackas Ephemeral environment spinning up at http://34.216.33.80:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 28 '24 17:05 github-actions[bot]

Works great! Thanks again!

rusackas avatar May 28 '24 18:05 rusackas

Ephemeral environment shutdown and build artifacts deleted.

github-actions[bot] avatar May 28 '24 18:05 github-actions[bot]