superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: Data Zoom scrolls using the mouse

Open visharavana opened this issue 1 year ago • 3 comments

SUMMARY

To scroll in the data zoom option, we initially had to press and hold down the zoom handle, but now we can also use the mouse for this function.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

https://github.com/apache/superset/assets/126564878/725c9eef-f269-4b6d-922e-ab0dd0137a84

After:

https://github.com/apache/superset/assets/126564878/7e0374c6-0d8d-44f3-bab0-7caf5562308e

ADDITIONAL INFORMATION

  • [ ] Introduces new feature or API

visharavana avatar May 17 '24 06:05 visharavana

Looks like you need to run the pre-commit hooks.

rusackas avatar May 17 '24 17:05 rusackas

Looks like you need to run the pre-commit hooks.

@rusackas I am new to this, so can you guide me?

visharavana avatar May 18 '24 09:05 visharavana

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.71%. Comparing base (5de4862) to head (210c61e). Report is 21 commits behind head on 4.0.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.0   #28559      +/-   ##
==========================================
+ Coverage   69.65%   69.71%   +0.05%     
==========================================
  Files        1910     1912       +2     
  Lines       74936    74923      -13     
  Branches     8425     8434       +9     
==========================================
+ Hits        52200    52231      +31     
+ Misses      20671    20627      -44     
  Partials     2065     2065              
Flag Coverage Δ
javascript 57.52% <ø> (+0.14%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 23:05 codecov[bot]