chore: deprecate multiple old APIs

[dpgaspar]

SUMMARY

Deprecates multiple old API endpoints and removes unused code:

List of deprecated endpoints:

 <Rule '/chart/add' (GET, HEAD, POST, OPTIONS) -> SliceModelView.add>,
 <Rule '/chart/api/delete/<pk>' (OPTIONS, DELETE) -> SliceModelView.api_delete>,
 <Rule '/chart/api/read' (GET, HEAD, OPTIONS) -> SliceModelView.api_read>,
 <Rule '/chart/delete/<pk>' (GET, HEAD, POST, OPTIONS) -> SliceModelView.delete>,
 <Rule '/chart/download/<filename>' (GET, HEAD, OPTIONS) -> SliceModelView.download>,
 <Rule '/chart/edit/<pk>' (GET, HEAD, POST, OPTIONS) -> SliceModelView.edit>,
 <Rule '/chart/list/' (GET, HEAD, OPTIONS) -> SliceModelView.list>,
 <Rule '/chart/show/<pk>' (GET, HEAD, OPTIONS) -> SliceModelView.show>,
 <Rule '/savedqueryview/add' (HEAD, POST, GET, OPTIONS) -> SavedQueryView.add>,
 <Rule '/savedqueryview/api/create' (POST, OPTIONS) -> SavedQueryView.api_create>,
 <Rule '/savedqueryview/api/delete/<pk>' (DELETE, OPTIONS) -> SavedQueryView.api_delete>,
 <Rule '/savedqueryview/api/get/<pk>' (HEAD, GET, OPTIONS) -> SavedQueryView.api_get>,
 <Rule '/savedqueryview/api/read' (HEAD, GET, OPTIONS) -> SavedQueryView.api_read>,
 <Rule '/savedqueryview/api/update/<pk>' (PUT, OPTIONS) -> SavedQueryView.api_update>,
 <Rule '/savedqueryview/delete/<pk>' (HEAD, POST, GET, OPTIONS) -> SavedQueryView.delete>,
 <Rule '/savedqueryview/edit/<pk>' (HEAD, POST, GET, OPTIONS) -> SavedQueryView.edit>,
 <Rule '/savedqueryview/list/' (HEAD, GET, OPTIONS) -> SavedQueryView.list>,
 <Rule '/savedqueryview/show/<pk>' (HEAD, GET, OPTIONS) -> SavedQueryView.show>,
 <Rule '/savedqueryviewapi/api/create' (POST, OPTIONS) -> SavedQueryViewApi.api_create>,
 <Rule '/savedqueryviewapi/api/get/<pk>' (HEAD, GET, OPTIONS) -> SavedQueryViewApi.api_get>,
 <Rule '/savedqueryviewapi/api/read' (HEAD, GET, OPTIONS) -> SavedQueryViewApi.api_read>,
 <Rule '/savedqueryviewapi/api/update/<pk>' (PUT, OPTIONS) -> SavedQueryViewApi.api_update>,

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• [ ] Has associated issue:
• [ ] Required feature flags:
• [ ] Changes UI
• [ ] Includes DB Migration (follow approval process in SIP-59)
  • [ ] Migration is atomic, supports rollback & is backwards-compatible
  • [ ] Confirm DB migration upgrade and downgrade tested
  • [ ] Runtime estimates and downtime expectations provided
• [ ] Introduces new feature or API
• [ ] Removes existing feature or API

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.19%. Comparing base (76d897e) to head (edbfed1). Report is 108 commits behind head on master.

Files	Patch %	Lines
superset-frontend/src/SqlLab/actions/sqlLab.js	50.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #28492      +/-   ##
==========================================
+ Coverage   60.48%   70.19%   +9.70%     
==========================================
  Files        1931     1944      +13     
  Lines       76236    77240    +1004     
  Branches     8568     8652      +84     
==========================================
+ Hits        46114    54215    +8101     
+ Misses      28017    20906    -7111     
- Partials     2105     2119      +14     

Flag	Coverage Δ
hive	49.08% <100.00%> (-0.09%)	:arrow_down:
javascript	57.74% <50.00%> (+0.02%)	:arrow_up:
mysql	77.14% <100.00%> (?)
postgres	77.25% <100.00%> (?)
presto	53.64% <100.00%> (-0.17%)	:arrow_down:
python	83.43% <100.00%> (+19.94%)	:arrow_up:
sqlite	76.70% <100.00%> (?)
unit	58.81% <100.00%> (+1.18%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[rusackas]

Not sure why we see this: