superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(i18n): Adding and modifying Japanese translations

Open aikawa-ohno opened this issue 9 months ago • 3 comments

SUMMARY

  • An unassigned translation was added.
  • Fixed translation with mismatched combinations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

aikawa-ohno avatar May 14 '24 05:05 aikawa-ohno

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.44%. Comparing base (76d897e) to head (847954f). Report is 122 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28487       +/-   ##
===========================================
+ Coverage   60.48%   77.44%   +16.96%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37422    -38814     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    28983    -17131     
+ Misses      28017     8439    -19578     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive ?
javascript ?
mysql 77.14% <ø> (?)
postgres 77.25% <ø> (?)
presto ?
python 77.44% <ø> (+13.96%) :arrow_up:
sqlite 76.70% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 14 '24 16:05 codecov[bot]

Looks like there are some linting issues, and you'll need to run the pre-commit hook for this to pass CI.

rusackas avatar May 14 '24 16:05 rusackas

Thank you for confirming. I fixed the line endings of the .po files, which were failing the CI.

aikawa-ohno avatar May 16 '24 03:05 aikawa-ohno