fix: Correction translation

[aehanno]

Correction french translation

SUMMARY

Remove to fuzzy to add the right translation

BEFORE

TESTING INSTRUCTIONS

Check that after we got the new translation

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 83.41232% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 67.27%. Comparing base (76d897e) to head (f8bd651). Report is 109 commits behind head on master.

Files	Patch %	Lines
...t-frontend/src/explore/actions/saveModalActions.ts	87.62%	7 Missing and 5 partials :warning:
superset/views/base.py	82.35%	9 Missing :warning:
superset/migrations/shared/utils.py	25.00%	6 Missing :warning:
superset/views/database/views.py	81.48%	5 Missing :warning:
superset/db_engine_specs/presto.py	50.00%	2 Missing :warning:
...-frontend/src/features/alerts/AlertReportModal.tsx	66.66%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #28434      +/-   ##
==========================================
+ Coverage   60.48%   67.27%   +6.79%     
==========================================
  Files        1931     1944      +13     
  Lines       76236    77305    +1069     
  Branches     8568     8671     +103     
==========================================
+ Hits        46114    52010    +5896     
+ Misses      28017    23171    -4846     
- Partials     2105     2124      +19     

Flag	Coverage Δ
hive	?
javascript	57.73% <87.00%> (+0.01%)	:arrow_up:
mysql	77.12% <80.18%> (?)
postgres	77.23% <80.18%> (?)
presto	?
python	77.43% <80.18%> (+13.94%)	:arrow_up:
sqlite	76.68% <80.18%> (?)
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[aehanno]

As it is link to this issue https://github.com/apache/superset/issues/28431

@rusackas, Do you know what I can do about the Docker error? I didn't modify that part, so I don't understand why I'm getting this error

Thanks

[john-bodley]

@aehanno regarding the Docker issue, would you mind rebasing?

[mistercrunch]

We really need to pull the .json files out of the repository. @rusackas any blockers on removing those files?

[aehanno]

@aehanno regarding the Docker issue, would you mind rebasing?

I merge master and did the rebase

[rusackas]

We really need to pull the .json files out of the repository. @rusackas any blockers on removing those files?

Just that people won't have translations anymore... I think you can expect a lot of Issues if that happens. That can be considered as a "breaking change" for 5.0 inclusion if you want to add it to the 5.0 Kanban.

On a related note, there was just an issue where people made a case for bringing the .mo files back. I agree we shouldn't have to include the .json and .mo files in the code base, but to remove them I would hope/expect that they're auto-generated (and gitignored) when installing/starting Superset.

[mistercrunch]

Assuming we would:

• add to docker build
• add to official pypi release process
• adapt docs/build instructions

I guess that leaves people building from the repo directly out

From the perspective of pypi/docker it's not a breaking change. For the rest, maybe a note in UPDATING.md suffice?

[rusackas]

For others' context, there's a somewhat parallel discussion happening here: https://github.com/apache/superset/issues/25988

I think it's fair to remove the .mo/.json files if the're auto-generated at a time that supports as many use cases as possible. I'm not sure if dockery/pypi cover all the bases one would expect.

If this were to be done at start time, I think it's pretty quick, but it might be possible to even do it conditionally depending on configuration... then those who have translations enabled always run the freshest translations, no matter how they install/run Superset.

[aehanno]

@rusackas It will impact what I did ? Do I need to change something on my PR Because I change the po files then with the po2json I generated the json file

[rusackas]

@aehanno I think your PR is OK... we're just trying to figure out what to do with the json files, and it's just kind of happening on this thread randomly.

[rusackas]

Actually @aehanno, in looking at the PR files, there are a whole lot of changed files that look like they have nothing to do with translations. Maybe the rebase didn't work right?

[aehanno]

Actually @aehanno, in looking at the PR files, there are a whole lot of changed files that look like they have nothing to do with translations. Maybe the rebase didn't work right?

I did another merge and rebase but I still got those change I don't know why

The diff is weird beacause if we check the first file for example, that say I change the version from 4.0.0 to 4.0.1 but I checked the same file in master branch and I got 4.0.1

[rusackas]

Yeah, something here isn't right. I suspect you're merging master onto your feature branch rather than rebasing. @mistercrunch might have the git-fu to get us out of this mess, but here's a randomly-slected article on the difference that miiiight help.

[aehanno]

@rusackas Can be a solution to create a new branch then the pull request ? Instead of did the correction on this one

[rusackas]

@aehanno absolutely. I've definitely done it several times :D

[aehanno]

New PR here https://github.com/apache/superset/pull/28497