superset icon indicating copy to clipboard operation
superset copied to clipboard

Published 20 hours ago • verified publisher icon apache

fix(ar-modal): updateNotificationSettings not updating state

Open fisjac opened this issue 9 months ago • 0 comments

SUMMARY

When changing the recipients list for an existing notification method, the state is not being changed properly. This change addresses this by reinstating missing code that was lost in a previous PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [x] Has associated issue: https://github.com/apache/superset/issues/28149#issuecomment-2100612644
  • [x] Required feature flags: ALERT_REPORTS
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

fisjac avatar May 09 '24 16:05 fisjac