superset icon indicating copy to clipboard operation
superset copied to clipboard

chore: deprecate old Database endpoints

Open dpgaspar opened this issue 1 year ago • 3 comments

SUMMARY

Deprecates all database views (server rendered) for databases

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

dpgaspar avatar May 09 '24 14:05 dpgaspar

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 83.27%. Comparing base (76d897e) to head (b3fb911). Report is 75 commits behind head on master.

Files Patch % Lines
superset/views/database/views.py 81.48% 5 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28404       +/-   ##
===========================================
+ Coverage   60.48%   83.27%   +22.78%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37255    -38981     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31024    -15090     
+ Misses      28017     6231    -21786     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.10% <77.77%> (-0.07%) :arrow_down:
javascript ?
mysql 77.23% <81.48%> (?)
postgres 77.35% <81.48%> (?)
presto 53.69% <77.77%> (-0.12%) :arrow_down:
python 83.27% <81.48%> (+19.78%) :arrow_up:
sqlite 76.81% <81.48%> (?)
unit 58.37% <77.77%> (+0.75%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 09 '24 14:05 codecov-commenter

@supersetbot orglabel

mistercrunch avatar May 10 '24 01:05 mistercrunch

Not sure why supersetbot orglabel, but seems limited to @dpgaspar , unclear why, this should swallow the error for now https://github.com/apache/superset/pull/28418

mistercrunch avatar May 10 '24 01:05 mistercrunch