apache
fix(explore): hide advanced analytics for non temporal xaxis
SUMMARY
The superset feature allows users to choose a non-temporal column for the x-axis. However, when a non-temporal column is selected, advanced analytics and forecast options are not compatible.
In order to address this, UI should dynamically hide these features when a non-temporal column is selected. This commit introduces the visibility option in the ControlPanelSectionConfig, enabling the hiding of specific groups of controlSets.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://github.com/apache/superset/assets/1392866/19b5c98d-415d-4b4e-9454-c4eb21b5a65a
After:
https://github.com/apache/superset/assets/1392866/b1439a88-6090-482d-8c96-3de8610918ec
TESTING INSTRUCTIONS
Choose non-temporal column in x-axis option Verify that "Advanced analytics" and "Predictive Analytics" sections are hidden
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@justinpark Can you also make sure to ignore or remove the values from the form data in case a user starts with a temporal column, fills the advanced properties and later changes to a categorial x-axis?
@justinpark Can you also make sure to ignore or remove the values from the form data in case a user starts with a temporal column, fills the advanced properties and later changes to a categorial x-axis?
Done
@Vovch are you saying this introduced a bug? Based on your comment I am trying this out in 4.0.2rc1 and indeed experiencing something that might be a bug. I created a new issue https://github.com/apache/superset/issues/29331 for it and would appreciate if you can expand on whether this is what you were talking about.
