superset icon indicating copy to clipboard operation
superset copied to clipboard

chore: use depth=1 for cloning

Open rantoniuk opened this issue 9 months ago • 1 comments

It's not needed to clone full history of the repository just to get and spin up docker compose.

rantoniuk avatar Apr 30 '24 13:04 rantoniuk

I'm not against the idea, but there's something nice in using vanilla commands. Say a more junior git user may be confused when trying to checkout a tag after making a shallow clone. More senior users know when to shallow-clone - say if they intent to make small contribution and such.

grepping for git clone:

$ git grep "git clone" docs/
docs/docs/contributing/development.mdx:git clone [email protected]:your-username/superset.git
docs/docs/installation/docker-compose.mdx:git clone https://github.com/apache/superset.git
docs/docs/quickstart.mdx:$ git clone https://github.com/apache/superset

quickstart.mdx is probably the place where shallow-cloning would make most sense.

mistercrunch avatar Apr 30 '24 15:04 mistercrunch