superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(maps): Adding ALL the countries to the Country Map plugin! 🌎

Open rusackas opened this issue 1 year ago β€’ 8 comments

SUMMARY

So... after much ado of getting the Jupyter Notebook up to snuff, this PR adds as many of the countries as I could support. It pulls things from Natural Earth data just... as they are. We might need to adjust some disputed territories, move some islands closer to the mainland, etc., but in broad strokes, this should make us truly global, and we can continue to make overrides to Natural Earth in the notebook as we always have.

This does even more now!

  • Strips out countries that have only one region, and would therefore be useless as a choropleth
  • Standardizes display of maps (now with more colors!)
  • Organizes a bit and cleans out some useless cells
  • Pretties up the country preview grid
  • Simplifies geometry for the country preview grid
  • Skips the first preview_all_countries, since it takes a while and you don't ususally need it
  • Adds a TODO list of countries that could use layout adjustments due to distant islands.
  • Removes the legacy countries_custom folder of geojson files... let's not have that!
  • adds a "speed run" mode that skips rendering charts, and makes it WAAAAAY faster to just update maps locally or as part of CI.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rusackas avatar Apr 29 '24 16:04 rusackas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.48%. Comparing base (76d897e) to head (068143f). Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28265      +/-   ##
==========================================
- Coverage   60.48%   60.48%   -0.01%     
==========================================
  Files        1931     1931              
  Lines       76236    76236              
  Branches     8568     8568              
==========================================
- Hits        46114    46108       -6     
- Misses      28017    28020       +3     
- Partials     2105     2108       +3     
Flag Coverage Ξ”
javascript 57.69% <ΓΈ> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 30 '24 04:04 codecov-commenter

/testenv up

rusackas avatar Apr 30 '24 17:04 rusackas

@rusackas Ephemeral environment spinning up at http://35.163.143.161:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 30 '24 17:04 github-actions[bot]

Just need a codeowner review from @villebro to get this done :)

rusackas avatar May 01 '24 01:05 rusackas

/testenv up

rusackas avatar May 08 '24 07:05 rusackas

@rusackas Ephemeral environment spinning up at http://54.185.8.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 08 '24 07:05 github-actions[bot]

/testenv up

rusackas avatar May 08 '24 14:05 rusackas

@rusackas Ephemeral environment spinning up at http://54.184.51.66:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]

Ephemeral environment shutdown and build artifacts deleted.

github-actions[bot] avatar May 15 '24 21:05 github-actions[bot]