superset icon indicating copy to clipboard operation
superset copied to clipboard

Slider step size is incorrect in some cases

Open eyalezer opened this issue 1 year ago • 0 comments

Bug description

Due to this PR: https://github.com/apache/superset/pull/27271 the step size is rounded to 1 in cases max - min is greater than 1, for example in case max = 1.75 and min = 0.25 the slider step size will be set to 1 and therefor this will be the only slider option available when using it. There are multiple ways of resolving this issue for instance having a bigger minimum number when comparing at line: RangeFilterPlugin.tsx:311 or having another controlPanel config for the filter to set the step size manually or the delta value like suggested before.

Before raising any PR i would like hear what you guys think regarding the different options we can tackle this issue

How to reproduce the bug

have max and min delta value grater than 1

Screenshots/recordings

No response

Superset version

3.1.2

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
  • [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
  • [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

eyalezer avatar Apr 28 '24 19:04 eyalezer