superset icon indicating copy to clipboard operation
superset copied to clipboard

Drawback on latest version 4.0.0 dashboard grid

Open JatinVenkatesh opened this issue 1 year ago • 0 comments
trafficstars

OLD s2

NEW s3

In the older version we were able to create different layout templates, but in the latest version we have some limitations in the dashboard grid.

JatinVenkatesh avatar Apr 25 '24 07:04 JatinVenkatesh

:+1: A year or so ago, I've experimented with a "ChainingMaker" that combines one or more makers into a new maker: https://github.com/wouterj/maker-bundle/commit/7c090609445a3029ac1e0cc7d674ca87a4716ab5 I stopped because I was unsure about this direction. Maybe we should instead add support for doing $this->run('make:user', [...]) and create a complete new maker.

Btw, I've stopped working on something like this because I think it's required to first work on make:auth: https://github.com/symfony/maker-bundle/issues/1049

wouterj avatar Jan 18 '22 16:01 wouterj

I've been messing around with this concept myself. I can see the pros and cons of chaining commands vs a new "all-in-one" maker that reuses logic from existing makers in the form of services.

I started with the chaining approach, but that quickly became a headache. transforming the various bits in the existing makers to services that can be consumed by other makers became a headache as well. That being said, I think we should definitely figure out the best path forward to @wouterj original idea of having a single command to setup everything to do with authentication.

Once we nail down the approach that we should take - implementing the concept into something usable would open the door to additional cleanup within the code base depending on which direction we go.

jrushlow avatar Jan 18 '22 16:01 jrushlow

I've experimented with my other suggestion and I must say that I quite like the end result: https://github.com/symfony/maker-bundle/compare/main...wouterj:nested-makers

This gives us all flexibility to create a nice interaction in the new make:security command, while still reusing the logic from the other security makers.

wouterj avatar Jan 20 '22 14:01 wouterj