superset icon indicating copy to clipboard operation
superset copied to clipboard

chore(applitools): making tests more static for consistent testing

Open rusackas opened this issue 1 year ago • 1 comments

SUMMARY

Applitools is throwing visual regression errors because of things like Date.now()... this branch will serve as a place to start locking these things down as static, so our tests will be more meaningful than ignoring these zones in countless places.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rusackas avatar Apr 24 '24 16:04 rusackas

@geido I never got around to doing more of this Applitools stabilization. Should we just merge this one, and eventually open more like it?

rusackas avatar May 08 '24 07:05 rusackas

@justinpark @michael-s-molina might as well merge this thing if you don't see any reason not to. It fixes up the appltools stability of just one test. I thought I'd go deeper and grow the PR, but just haven't had time to.

rusackas avatar Jun 07 '24 19:06 rusackas