superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(table): Table with Time Comparison

Open Antonio-RiveroMartnez opened this issue 10 months ago • 29 comments

SUMMARY

As part of the Time Comparison efforts, we are adding the new controls to the table viz.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Set up a table viz using the new time comparison controls

ADDITIONAL INFORMATION

  • [ ] Has associated issue: https://github.com/apache/superset/issues/27432
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

Antonio-RiveroMartnez avatar Apr 16 '24 13:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez can this feature support PIVOT TABLE ? I tested and found not.

Smallhi avatar Apr 19 '24 09:04 Smallhi

@Antonio-RiveroMartnez can this feature support PIVOT TABLE ? I tested and found not.

Hey @Smallhi , so far it's not part of the pivot table as you pointed out. Once merged we can consider bringing this to other visualizations like pivot etc, thanks for asking.

Antonio-RiveroMartnez avatar Apr 23 '24 21:04 Antonio-RiveroMartnez

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

Antonio-RiveroMartnez avatar Apr 24 '24 00:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.217.78.9:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 24 '24 00:04 github-actions[bot]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

Antonio-RiveroMartnez avatar Apr 24 '24 13:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.91.233.244:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 24 '24 13:04 github-actions[bot]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

lilykuang avatar Apr 24 '24 18:04 lilykuang

@lilykuang Ephemeral environment spinning up at http://34.219.209.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 24 '24 18:04 github-actions[bot]

/testenv up

Antonio-RiveroMartnez avatar Apr 25 '24 13:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.94.33.211:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 25 '24 13:04 github-actions[bot]

/testenv up

Antonio-RiveroMartnez avatar Apr 25 '24 15:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.219.149.143:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 25 '24 15:04 github-actions[bot]

/testenv up

Antonio-RiveroMartnez avatar Apr 25 '24 16:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.219.156.16:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 25 '24 16:04 github-actions[bot]

/testenv up

Antonio-RiveroMartnez avatar Apr 26 '24 12:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://54.218.71.76:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 26 '24 13:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 42.90844% with 318 lines in your changes missing coverage. Please review.

Project coverage is 67.19%. Comparing base (76d897e) to head (7c262ef). Report is 302 commits behind head on master.

Files Patch % Lines
...d/plugins/plugin-chart-table/src/transformProps.ts 22.58% 83 Missing and 13 partials :warning:
...tend/plugins/plugin-chart-table/src/TableChart.tsx 24.24% 62 Missing and 13 partials :warning:
.../explore/components/controls/TimeOffsetControl.tsx 1.42% 69 Missing :warning:
...plore/components/controls/ComparisonRangeLabel.tsx 13.63% 19 Missing :warning:
...ntend/plugins/plugin-chart-table/src/buildQuery.ts 45.16% 10 Missing and 7 partials :warning:
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 15.38% 10 Missing and 1 partial :warning:
...Number/BigNumberPeriodOverPeriod/transformProps.ts 0.00% 9 Missing :warning:
...onalFormattingControl/FormattingPopoverContent.tsx 10.00% 9 Missing :warning:
.../BigNumber/BigNumberPeriodOverPeriod/buildQuery.ts 0.00% 7 Missing :warning:
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 25.00% 0 Missing and 3 partials :warning:
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28057      +/-   ##
==========================================
+ Coverage   60.48%   67.19%   +6.70%     
==========================================
  Files        1931     1957      +26     
  Lines       76236    77825    +1589     
  Branches     8568     8940     +372     
==========================================
+ Hits        46114    52293    +6179     
+ Misses      28017    23342    -4675     
- Partials     2105     2190      +85     
Flag Coverage Δ
hive ?
javascript 57.78% <42.90%> (+0.06%) :arrow_up:
presto ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 30 '24 01:04 codecov-commenter

/testenv up

Antonio-RiveroMartnez avatar Apr 30 '24 08:04 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.219.17.169:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Apr 30 '24 08:04 github-actions[bot]

/testenv up

yousoph avatar May 04 '24 07:05 yousoph

@yousoph Ephemeral environment spinning up at http://54.187.214.0:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 04 '24 07:05 github-actions[bot]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

Antonio-RiveroMartnez avatar May 20 '24 22:05 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.93.41.232:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 20 '24 23:05 github-actions[bot]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

Antonio-RiveroMartnez avatar May 21 '24 14:05 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.215.152.130:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 21 '24 15:05 github-actions[bot]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

Antonio-RiveroMartnez avatar May 21 '24 20:05 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.210.222.153:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 21 '24 20:05 github-actions[bot]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

Antonio-RiveroMartnez avatar May 22 '24 14:05 Antonio-RiveroMartnez

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://52.89.241.120:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 22 '24 14:05 github-actions[bot]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

lilykuang avatar Jun 12 '24 02:06 lilykuang