superset icon indicating copy to clipboard operation
superset copied to clipboard

refactor: Migrate saveModalActions to TypeScript

Open EnxDev opened this issue 1 year ago • 5 comments

SUMMARY

Migrate saveModalActions to TypeScript

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A

TESTING INSTRUCTIONS

  • All tests should pass

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

EnxDev avatar Apr 15 '24 23:04 EnxDev

/testenv up

geido avatar May 03 '24 12:05 geido

@geido Ephemeral environment spinning up at http://52.38.63.144:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 03 '24 12:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 87.62887% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 60.25%. Comparing base (2e5f3ed) to head (3eb0a93). Report is 29 commits behind head on master.

Files Patch % Lines
...t-frontend/src/explore/actions/saveModalActions.ts 87.62% 7 Missing and 5 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28046      +/-   ##
==========================================
- Coverage   60.49%   60.25%   -0.25%     
==========================================
  Files        1931     1928       -3     
  Lines       76241    75960     -281     
  Branches     8566     8585      +19     
==========================================
- Hits        46122    45767     -355     
- Misses      28015    28084      +69     
- Partials     2104     2109       +5     
Flag Coverage Δ
hive ?
javascript 57.72% <87.62%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 03 '24 17:05 codecov-commenter

/testenv up

geido avatar May 10 '24 15:05 geido

@geido Ephemeral environment spinning up at http://35.166.154.194:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar May 10 '24 16:05 github-actions[bot]

Ephemeral environment shutdown and build artifacts deleted.

github-actions[bot] avatar May 14 '24 14:05 github-actions[bot]