fix: spell error analagous -> analogous
fix(spell): analagous -> analogous
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Thank you for the PR. Unfortunately, I believe since some people flip these flags by all sorts of means of automation, this is considered a breaking change, and we'll have to wait until 5.0. I'll put it on that project board, and we can keep this PR open until then (though it might need rebasing at some point).
This has bugged me in the past so I'm pleased to see this PR. I agree about waiting until 5.0.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.24%. Comparing base (
76d897e) to head (1ce8796). Report is 1297 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #27930 +/- ##
==========================================
+ Coverage 60.48% 70.24% +9.76%
==========================================
Files 1931 1949 +18
Lines 76236 77553 +1317
Branches 8568 8731 +163
==========================================
+ Hits 46114 54480 +8366
+ Misses 28017 20944 -7073
- Partials 2105 2129 +24
| Flag | Coverage Δ | |
|---|---|---|
| hive | 49.12% <ø> (-0.04%) |
:arrow_down: |
| javascript | 57.84% <100.00%> (+0.12%) |
:arrow_up: |
| mysql | 77.19% <ø> (?) |
|
| postgres | 77.30% <ø> (?) |
|
| presto | 53.67% <ø> (-0.13%) |
:arrow_down: |
| python | 83.50% <ø> (+20.01%) |
:arrow_up: |
| sqlite | 76.75% <ø> (?) |
|
| unit | 58.97% <ø> (+1.34%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR needed a rebase and a few tweaks, so I just opened a new one rather than bothering @zhangymPerson to update things here again. You get full credit for this, thank you for catching and fixing it! I think we can close this one and merge my copycat PR when CI passes, now that the 5.0 breaking window is open.