superset icon indicating copy to clipboard operation
superset copied to clipboard

Published 20 hours ago • verified publisher icon apache

fix: data in table with time comparison without change should be grey

Open lilykuang opened this issue 10 months ago • 1 comments

SUMMARY

When color options are applied on tables and there has been no change (no increase or decrease), we should leave the table color as grey for that row/cell instead of using the orange.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Screen Shot 2024-04-04 at 5 40 30 PM After: Screen Shot 2024-04-04 at 5 35 21 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

lilykuang avatar Apr 05 '24 00:04 lilykuang

@lilykuang Wouldn't be better to not apply a background color if there was no change?

michael-s-molina avatar Apr 05 '24 19:04 michael-s-molina