superset icon indicating copy to clipboard operation
superset copied to clipboard

[DO NOT MERGE] DEMO fix(time_comparison):Use Join queries when using time comparison

Open Antonio-RiveroMartnez opened this issue 10 months ago • 0 comments

SUMMARY

To facilitate the discussion related our experimental feature for time comparison, we're extracting out form the original PR all the back end changes related to how to create left outer join queries when time comparison is needed. Using JOIN statement would help tackling issues related to Row Limit discussed in this issue. Right now we are raising an exception message to users that try to generate these joined queries on databases where JOINs are not supported.

Known limitations:

  • This approach only supports one time comparison at the time and doesn't rely on the time_offset property in the QueryObject, meaning that it's not compatible with existing API that allows for multiple ranges using such property.
  • We are raising en exception when JOINs are not supported, we should instead fallback to time_offset API that applies the joins on DataFrame level

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

Antonio-RiveroMartnez avatar Apr 02 '24 13:04 Antonio-RiveroMartnez