feat(translations): cleaning and adding scripts for translations - working toward automation
SUMMARY
Ok, so we're working toward solidifying/stabilizing translation efforts. Here's another step in the chain, where we:
- Remove
.jsontranslation files from the repo and add them to.gitignore - Tweak the
.jsonbuilding script so it can be run from a newnpm run build-translationsscript - Build those translations whenever doing
npm run buildorbuild-instrumented - Remove translation code owners - they shouldn't be needed now that people won't likely edit the
.jsonfiles. - Removes two
npmscripts for linting translations. From here on out, you just get what you get, and it'll work :) - Removing translation lint check on CI, as that's no longer relevant.
Next steps/PRs:
- add a CI task that updates the
.potfile and.pofiles on any PR that touches.pyor.(j|t)s(x)files. - build the translation files on docker builds
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 59.57%. Comparing base (
a912faf) to head (2acbc8e). Report is 52 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #27107 +/- ##
==========================================
- Coverage 67.17% 59.57% -7.61%
==========================================
Files 1900 1900
Lines 74430 74430
Branches 8293 8293
==========================================
- Hits 50001 44343 -5658
- Misses 22374 28032 +5658
Partials 2055 2055
| Flag | Coverage Δ | |
|---|---|---|
| hive | 53.80% <ø> (?) |
|
| javascript | 56.86% <ø> (ø) |
|
| mysql | ? |
|
| postgres | ? |
|
| presto | 53.75% <ø> (?) |
|
| python | 62.48% <ø> (-15.78%) |
:arrow_down: |
| sqlite | ? |
|
| unit | 56.42% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Wow... of all things, the DB tests are failing spectacularly. Not sure what to make of this yet.
We should probably also update the translation section in CONTRIBUTING.md.
I think everything here is superseeded by https://github.com/apache/superset/pull/28483