superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(deps): un-bumping dom-to-pdf ro resolve missing file warnings

Open rusackas opened this issue 1 year ago • 2 comments

SUMMARY

For some reason, a bump of this package seemed to cause these annoying errors image

Taking it back down one patch version seems to resolve them :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue: Fixes https://github.com/apache/superset/issues/27089
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rusackas avatar Feb 12 '24 21:02 rusackas

linking associated issue: https://github.com/apache/superset/issues/27089

fisjac avatar Feb 12 '24 21:02 fisjac

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e8e208d) 67.17% compared to head (e1ca6ec) 67.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27091   +/-   ##
=======================================
  Coverage   67.17%   67.18%           
=======================================
  Files        1900     1900           
  Lines       74443    74443           
  Branches     8293     8293           
=======================================
+ Hits        50009    50012    +3     
+ Misses      22379    22376    -3     
  Partials     2055     2055           
Flag Coverage Δ
javascript 56.87% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 21:02 codecov[bot]