chore(internet_port): added new ports and removed unnecessary string class

[anirudh-hegde]

SUMMARY

Added new ports and removed unnecessary string class

https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?&page=6

[john-bodley]

Thanks @anirudh-hegde for the change. @cccs-tom would you mind taking a look at this?

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4796484) 67.18% compared to head (3ba27e5) 69.50%. Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #27078      +/-   ##
==========================================
+ Coverage   67.18%   69.50%   +2.32%     
==========================================
  Files        1900     1900              
  Lines       74443    74433      -10     
  Branches     8293     8293              
==========================================
+ Hits        50012    51733    +1721     
+ Misses      22376    20645    -1731     
  Partials     2055     2055              

Flag	Coverage Δ
hive	53.80% <0.00%> (?)
mysql	78.02% <0.00%> (-0.01%)	:arrow_down:
postgres	78.12% <0.00%> (-0.01%)	:arrow_down:
presto	53.75% <0.00%> (?)
python	83.08% <100.00%> (+4.82%)	:arrow_up:
sqlite	77.64% <0.00%> (-0.01%)	:arrow_down:
unit	56.42% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[villebro]

@anirudh-hegde please check the linting errors:

[villebro]

@anirudh-hegde there's still that trailing whitespace issue:

superset/advanced_data_type/plugins/internet_port.py:93:0: C0303: Trailing whitespace (trailing-whitespace)

[anirudh-hegde]

It means in line 91 - 93 there is a trailing whitespace?

[anirudh-hegde]

I used pylint internet_port.py

[anirudh-hegde]

Ohh my bad!! I merged branch 'apache:master' into spear

[anirudh-hegde]

Should I need to change the code?

[rusackas]

Looks like you just need to run the pre-commit hook and you should be OK.

[anirudh-hegde]

Looks like you just need to run the pre-commit hook and you should be OK.

Hey @rusackas, I used pre-commit run --all-files

[anirudh-hegde]

Looks like you just need to run the pre-commit hook and you should be OK.

You were right. Thank you, @rusackas