Icon and Api Tasks
Task 1: Replicate Superset Frontend Login To Generate Dynamic Forms To connect to external API resources Task 2: Adding Custom Icons to Database Form To enhance user interface of the database connection form by adding custom icons for MySQL databases
SUMMARY
Issues install superset, stuck on welcome page after logging in to Apache Superset and frontend could not be fully build due to npm ci command taking a very long time with no final output. The below includes instructions as well as steps would have been taken if these issues were not present.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Task 1: -Installed the database driver for rockset api: pip install rockset-sqlalchemy
- login to apache superset
- click database
- click supported databases, then click other
- in the SQLALCHEMY URI section, enter the connection string for rockset: rockset://{slzXRHem1lebeo13tDp9LqaeItDIJ201GWOhjcrbWelAQTxmHntftKWfntmvfwS5}:@{api.use1a1.rockset.com}
- Use this as guide for other connection string formats for other APIs: https://superset.apache.org/docs/databases/installing-database-drivers/
- click test connection, then connect
Task 2:
- Added a link to the MySQL image in the superset_text.yml file : mysql.jpg
- superset/superset/config.py contained a section referring to the 'preferred_databases'. MySQL already mentioned in that part so no need to add it in -go to database page, then to Connect a Database form
- enter parameters such as: localhost, host, database name -click connect -restart (run dev-server)
ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Required feature flags:
- [x ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ x] Introduces new feature or API
- [ ] Removes existing feature or API
I think there are a few things that need to be dialed in here (and perhaps broken up into different PRs, if they're different tasks/problems)
- Adding the MySQL image is fine... but it should be part of the repo's files like the others, rather than a remote/hosted file.
- You mention adding a driver, but I don't see it in the PR.
- There's an API key included in the changes... probably accidental? You might want to rotate that key now that it's been made public.
- If the D3 dependency is causing problems (nobody else has reported it yet) can you elaborate on that?