superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(storybook): Co-habitating/Upgrading Storybooks to 7

Open rusackas opened this issue 1 year ago • 0 comments

SUMMARY

This PR does the following:

  • Temporarily removes the deny-list for license types. For some reason it's blocking a goofily-licensed submodule, which is perfectly license compatible (MIT). I'll flip this back on once I'm done with this effort.
  • Upgrades BOTH the Superset Storybook and superset-ui-demo to Storybook 7
  • Fixes all the Stories to use Controls instead of Knobs
  • Includes all the Stories from superset-ui-demo in the main Superset storybook (you can still run either though)
  • Fixes a bunch of little random bugs along the way
  • Removes a bunch of package vulnerabilities

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rusackas avatar Jan 31 '24 00:01 rusackas