fix(sqllab): flaky json explore modal due to over-rendering
SUMMARY
This commit reopens #26156, which resolves the issue detailed in https://github.com/apache/superset/issues/26276 by excluding the changes in 'QueryAutoRefresh/index.tsx' and 'reducers/sqlLab.js'. This commit also reverses the changes introduced in #18934. Now that the issue of overrendering due to redux has been resolved, it also effectively addresses the problem outlined in issue #26755.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://github.com/apache/superset/assets/1392866/8d81ba78-7142-438c-8c5c-b5049ef6ea94
After:
https://github.com/apache/superset/assets/1392866/c2023683-47f1-4a45-97c0-c14e4d7b6469
TESTING INSTRUCTIONS
Go to SQL Lab and run a query contains a json blob
Select a table in order to execute a table preview query
Click Results tab before the table preview query ends and then click the JSON column to open the JSON modal
Check the JSON modal persists while the async query status is updating
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.
Comparison is base (
f8c75ca) 67.19% compared to head (821a709) 67.19%. Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #26791 +/- ##
=======================================
Coverage 67.19% 67.19%
=======================================
Files 1899 1900 +1
Lines 74368 74370 +2
Branches 8274 8277 +3
=======================================
+ Hits 49969 49973 +4
+ Misses 22344 22343 -1
+ Partials 2055 2054 -1
| Flag | Coverage Δ | |
|---|---|---|
| javascript | 56.91% <85.18%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/testenv up
@justinpark Container image not yet published for this PR. Please try again when build is complete.
@justinpark Ephemeral environment creation failed. Please check the Actions logs for details.
/testenv up
@michael-s-molina Container image not yet published for this PR. Please try again when build is complete.
@michael-s-molina Ephemeral environment creation failed. Please check the Actions logs for details.
cc @gaurav7261
/testenv up
@justinpark Ephemeral environment spinning up at http://54.245.8.160:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.
@justinpark any reason not to merge this?
Ephemeral environment shutdown and build artifacts deleted.