superset icon indicating copy to clipboard operation
superset copied to clipboard

chore(translations): updating pot -> po -> json files (babel 2.9.1)

Open rusackas opened this issue 1 year ago • 3 comments

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rusackas avatar Jan 24 '24 05:01 rusackas

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e8e208d) 67.17% compared to head (8d92684) 69.50%. Report is 1 commits behind head on master.

Files Patch % Lines
superset/views/api.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26773      +/-   ##
==========================================
+ Coverage   67.17%   69.50%   +2.32%     
==========================================
  Files        1900     1900              
  Lines       74443    74443              
  Branches     8293     8293              
==========================================
+ Hits        50009    51739    +1730     
+ Misses      22379    20649    -1730     
  Partials     2055     2055              
Flag Coverage Δ
hive 53.81% <0.00%> (?)
mysql 78.03% <0.00%> (ø)
postgres 78.13% <0.00%> (ø)
presto 53.76% <0.00%> (?)
python 83.09% <0.00%> (+4.82%) :arrow_up:
sqlite 77.64% <0.00%> (ø)
unit 56.48% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 24 '24 05:01 codecov[bot]

Keeping this as a draft because it'll potentially overwrite a LOT of translation PRs.

rusackas avatar Jan 25 '24 02:01 rusackas

We can discuss it at Town Hall and/or Release Strategy... it might warrant a SIP or some form of consensus to make doing this something that happens at each major version release (since it can undo the work of others, which seems like a breaking change)

rusackas avatar Jan 25 '24 02:01 rusackas

Pulling in some new translation work from master and troubleshooting some files... should be current now! Also checked through some stuff with @mistercrunch and we believe that these updates should be largely non-breaking, since the pybable library seems pretty great about how it maps translation msgid fields, and our flow should not remove "obsolete" .po entries.

rusackas avatar Feb 12 '24 23:02 rusackas

Just need a codeowner approval from @michael-s-molina or @villebro and we should be good to go here.

rusackas avatar Feb 13 '24 01:02 rusackas

git rm superset/translations/*/*/*.json

mistercrunch avatar Feb 13 '24 01:02 mistercrunch