superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: copy multiarch scripts from master

Open AndrewChubatiuk opened this issue 1 year ago • 4 comments

fix: copy multiarch docker build scripts from master branch

SUMMARY

arm64 and amd64 images are currently built for master only. copied script from master to 3.1 release branch to have multiarch images in releases 3.1.x already

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

AndrewChubatiuk avatar Jan 11 '24 14:01 AndrewChubatiuk

Thanks @AndrewChubatiuk for the PR. Would you mind using the default PR template and describing in detail the motivation for the change?

@craig-rueda would you mind taking a look at reviewing the change, given that it Docker related?

john-bodley avatar Jan 11 '24 17:01 john-bodley

@john-bodley updated PR description

AndrewChubatiuk avatar Jan 16 '24 12:01 AndrewChubatiuk

Approved the CI here... pinging @mistercrunch since this relates to his recent efforts.

rusackas avatar Jan 31 '24 22:01 rusackas

I changed all of this in master very heavily, I'm unclear about the 3.1 branch. I guess the "release" github action will trigger from this branch, so this seems reasonable in that context.

mistercrunch avatar Jan 31 '24 22:01 mistercrunch