superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: add custom sort by x-axis for mixed charts

Open cmedley opened this issue 1 year ago • 2 comments

SUMMARY

Enables sorting mixed data chart by x-axis using different columns

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: image

After: image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

cmedley avatar Jan 03 '24 02:01 cmedley

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (29633e7) 69.14% compared to head (5d4da18) 69.14%. Report is 3 commits behind head on master.

Files Patch % Lines
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts 0.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26397      +/-   ##
==========================================
- Coverage   69.14%   69.14%   -0.01%     
==========================================
  Files        1946     1946              
  Lines       75989    75992       +3     
  Branches     8479     8480       +1     
==========================================
  Hits        52544    52544              
- Misses      21266    21268       +2     
- Partials     2179     2180       +1     
Flag Coverage Δ
javascript 56.45% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 03 '24 03:01 codecov[bot]

@cmedley I'm just finding that this slipped between the cracks somehow. Sorry about that. If you're willing to rebase PR to resolve conflicts, we can probably get a fresh review on it, and get it merged (finally). Thanks!

rusackas avatar Aug 26 '24 18:08 rusackas

Looks like this still hasn't gotten a rebase, and now the GENERIC_CHART_AXES flag used in the PR has been removed. I'll convert this to draft for now, in hopes that it can still be brought up to speed and marked ready for review again. If not, it may eventually be closed.

rusackas avatar Apr 22 '25 01:04 rusackas

if i try to sort with two or more Metrics then sort is not working , only one Metrics then it will work , can i get if you have any possible solution ..?

muralikrishnaIrakam avatar Jul 18 '25 14:07 muralikrishnaIrakam