superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(26338): replace chartsInScope references at import time

Open rdubois-kh opened this issue 1 year ago • 5 comments

SUMMARY

See the description here: https://github.com/apache/superset/issues/26338

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rdubois-kh avatar Jan 02 '24 08:01 rdubois-kh

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (29633e7) 69.14% compared to head (c6732c4) 69.14%. Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26389      +/-   ##
==========================================
- Coverage   69.14%   69.14%   -0.01%     
==========================================
  Files        1946     1946              
  Lines       75989    75992       +3     
  Branches     8479     8479              
==========================================
+ Hits        52544    52546       +2     
- Misses      21266    21267       +1     
  Partials     2179     2179              
Flag Coverage Δ
hive 53.68% <0.00%> (-0.01%) :arrow_down:
mysql 78.07% <0.00%> (+0.01%) :arrow_up:
postgres 78.16% <0.00%> (-0.01%) :arrow_down:
presto 53.63% <0.00%> (-0.01%) :arrow_down:
python 82.86% <100.00%> (-0.01%) :arrow_down:
sqlite 76.82% <0.00%> (-0.01%) :arrow_down:
unit 55.80% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 02 '24 18:01 codecov[bot]

Closing/reopening to kick-start CI. Also, @betodealmeida if you could review or nominate someone else, we'd appreciate it!

rusackas avatar Apr 18 '24 21:04 rusackas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.14%. Comparing base (29633e7) to head (c6732c4). Report is 781 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26389      +/-   ##
==========================================
- Coverage   69.14%   69.14%   -0.01%     
==========================================
  Files        1946     1946              
  Lines       75989    75992       +3     
  Branches     8479     8479              
==========================================
+ Hits        52544    52546       +2     
- Misses      21266    21267       +1     
  Partials     2179     2179              
Flag Coverage Δ
hive 53.68% <0.00%> (-0.01%) :arrow_down:
mysql 78.07% <0.00%> (+0.01%) :arrow_up:
postgres 78.16% <0.00%> (-0.01%) :arrow_down:
presto 53.63% <0.00%> (-0.01%) :arrow_down:
python 82.86% <100.00%> (-0.01%) :arrow_down:
sqlite 76.82% <0.00%> (-0.01%) :arrow_down:
unit 55.80% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 18 '24 21:04 codecov-commenter

@eschutho / @betodealmeida still hoping someone with more context on import/export can help review this :)

rusackas avatar Apr 24 '24 00:04 rusackas

All, as mentioned in https://github.com/apache/superset/issues/26338, a new commit has been added to the PR to make the charts references fix more complete as I missed a couple of locations where references were not updated at import time.

I guess the PR is re-ready for being reviewed. Thanks in advance.

rdubois-kh avatar Apr 26 '24 07:04 rdubois-kh