fix(Calendar Heatmap): Add Back chart options for Calendar Heatmap
SUMMARY
SIP: #26229
Adds chart options back to the Calendar Heatmap. The new list of Chart options is:
- Color Scheme
- Cell size
- Cell padding
- Cell Radius
- Color Steps
- Color Range
- Number/Time Formatting
- Legend Toggle
- Show Values Toggle
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
- Choose a dataset with time data
- Select a calendar heatmap to chart
- Change the different Chart options and check that they work properly
ADDITIONAL INFORMATION
- [x] Has associated issue: #26229
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
Project coverage is 69.18%. Comparing base (
fca5b82) to head (12856bb). Report is 1594 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...ugins/legacy-plugin-chart-calendar/src/Calendar.js | 0.00% | 2 Missing :warning: |
| ...legacy-plugin-chart-calendar/src/transformProps.js | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #26230 +/- ##
==========================================
- Coverage 69.18% 69.18% -0.01%
==========================================
Files 1945 1945
Lines 75948 75950 +2
Branches 8458 8458
==========================================
Hits 52546 52546
- Misses 21217 21219 +2
Partials 2185 2185
| Flag | Coverage Δ | |
|---|---|---|
| javascript | 56.51% <0.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @Mattc1221 for the change. Could you help provide some more context, i.e., regarding the PR title you state "Add Back ..." which would imply that these features previously existed. If this is the case would you mind referencing the PR(s) where this was removed?
Note ideally we hope to migrate the legacy calendar heatmap chart to ECharts, however currently there isn't feature parity. The concern is if we continue augmenting the legacy chart, the changes of eventually migrating to ECharts further diminishes.
Just noting that the SIP is open for voting. Hoping we can get some votes, and unblock this PR!
Hold label has been removed... @michael-s-molina you can release your hold if it's just for procedural reasons (though the PR still needs review).
@Mattc1221 this still has a couole small outstanding change requests. Do you want to revisit this and get it merged still? We appreciate it either way :D
Hey @Mattc1221 do you think you might still come back to this? If not, we might discard it (and the SIP) but obviously we'd much rather see it through if we can help.