feat(Alerts and Reports modal): Combine collective work into branch for testing [DO NOT MERGE]

[rtexelm]

SUMMARY

This combines changes from cobrafish (CorbinBullard, rtexelm, fisjac) into one branch allowing for tests of the full redesign. No changes have been made to the functioning purpose of the modal and no additional features have been included.

Design Proposal Contributing PR Contributing PR

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE: AFTER:

TESTING INSTRUCTIONS

• Open the Alerts & Reports page from the Settings drop menu
• Add a new report/alert or edit a report/alert

ADDITIONAL INFORMATION

• [ ] Has associated issue:
• [ ] Required feature flags:
• [X] Changes UI
• [ ] Includes DB Migration (follow approval process in SIP-59)
  • [ ] Migration is atomic, supports rollback & is backwards-compatible
  • [ ] Confirm DB migration upgrade and downgrade tested
  • [ ] Runtime estimates and downtime expectations provided
• [ ] Introduces new feature or API
• [ ] Removes existing feature or API

[codecov[bot]]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (60fe581) 67.15% compared to head (077a979) 69.52%. Report is 9 commits behind head on master.

Files	Patch %	Lines
...end/src/features/alerts/components/NumberInput.tsx	40.00%	2 Missing and 1 partial :warning:
...res/alerts/components/AlertReportCronScheduler.tsx	71.42%	1 Missing and 1 partial :warning:
...eatures/alerts/components/ValidatedPanelHeader.tsx	80.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26202      +/-   ##
==========================================
+ Coverage   67.15%   69.52%   +2.36%     
==========================================
  Files        1902     1905       +3     
  Lines       74441    74500      +59     
  Branches     8306     8324      +18     
==========================================
+ Hits        49994    51795    +1801     
+ Misses      22393    20649    -1744     
- Partials     2054     2056       +2     

Flag	Coverage Δ
hive	53.79% <100.00%> (?)
javascript	56.94% <96.00%> (+0.09%)	:arrow_up:
mysql	78.00% <100.00%> (-0.02%)	:arrow_down:
postgres	78.10% <100.00%> (-0.02%)	:arrow_down:
presto	53.74% <100.00%> (?)
python	83.07% <100.00%> (+4.82%)	:arrow_up:
sqlite	77.62% <100.00%> (-0.02%)	:arrow_down:
unit	56.42% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[lilykuang]

/testenv up FEATURE_ALERT_REPORTS=true

[github-actions[bot]]

@lilykuang Ephemeral environment spinning up at http://35.93.128.126:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[yousoph]

/testenv up

[github-actions[bot]]

@yousoph Ephemeral environment spinning up at http://34.219.202.1:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[yousoph]

/testenv up FEATURE_ALERT_REPORTS=true

[github-actions[bot]]

@yousoph Ephemeral environment spinning up at http://35.92.61.181:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

/testenv up FEATURE_ALERT_REPORTS=true

[github-actions[bot]]

@kgabryje Ephemeral environment spinning up at http://35.88.169.129:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

/testenv up FEATURE_ALERT_REPORTS=true

[geido]

/testenv up FEATURE_ALERT_REPORTS=true

[github-actions[bot]]

@geido Ephemeral environment spinning up at http://54.184.213.234:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

Could we remove that bottom border in the last collapsible?

[kgabryje]

Scheduling section looks a bit different than on the designs

EDIT: looks like react-js-cron was bumped from version 1.2 to 2.1 a week ago and now we should import its stylesheet explicitly

[geido]

/testenv up FEATURE_ALERT_REPORTS=true

[github-actions[bot]]

@geido Ephemeral environment spinning up at http://35.93.119.155:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

• (Reproduced on Master) I think it would be great if the input would catch this before submitting to the backend

• (Reproduced on Master) We should probably erase the value when setting the "Not null" option

• (Reproduced on Master) There is an issue with setting up a custom width for the screenshot and then choosing the CSV option. The custom width param will still be sent to the backend and will generate a validation error if it is below 600px. That should be cleared.

• (Reproduced on Master) Also, not sure why the input for the custom width does not behave like a standard numeric input (up and down arrows on focus).

• • I am still not clear about the reason why we chose to use a custom component rather than the one offered by Antd? CC @fisjac

• (Reproduced on Master) The grace period shows as optional. When editing the alert I found a value being set, even though I did not set it. When trying to erase it and save again, I will get the following error

• (Reproduced on Master) When setting a log retention of value None, I am getting an error that it should not be none :)

• (Reproduced on Master) When choosing a notification method, if I click by mistake on the same notification method, "Email" for instance, it will clear the email recipients. I believe it should clear them only if the notification method is different from the one selected.

• Probably not in the scope of this PR, but it would be nice to have some validation around the email field

[github-actions[bot]]

Ephemeral environment shutdown and build artifacts deleted.