feat(accessibility): add tabbing to chart menu in dashboard

[eschutho]

SUMMARY

This change adds the ability to tab through elements on a dashboard, the title, charts, and into the chart controls, and execute each of them with a keyboard.

https://github.com/apache/superset/assets/5186919/4dd70521-131a-438d-b370-ab7557e1176b

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• [ ] Has associated issue:
• [ ] Required feature flags:
• [ ] Changes UI
• [ ] Includes DB Migration (follow approval process in SIP-59)
  • [ ] Migration is atomic, supports rollback & is backwards-compatible
  • [ ] Confirm DB migration upgrade and downgrade tested
  • [ ] Runtime estimates and downtime expectations provided
• [ ] Introduces new feature or API
• [ ] Removes existing feature or API

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 65.16854% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 69.68%. Comparing base (1d571ec) to head (81efffb). Report is 3 commits behind head on master.

Files	Patch %	Lines
...dashboard/components/SliceHeaderControls/index.tsx	68.96%	17 Missing and 1 partial :warning:
...rontend/src/components/ErrorMessage/ErrorAlert.tsx	28.57%	10 Missing :warning:
...components/DashboardBuilder/DashboardContainer.tsx	25.00%	3 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26138      +/-   ##
==========================================
- Coverage   69.69%   69.68%   -0.01%     
==========================================
  Files        1908     1908              
  Lines       74530    74612      +82     
  Branches     8309     8333      +24     
==========================================
+ Hits        51942    51993      +51     
- Misses      20535    20565      +30     
- Partials     2053     2054       +1     

Flag	Coverage Δ
javascript	57.19% <65.16%> (+0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[eschutho]

/testenv up

[github-actions[bot]]

@eschutho Ephemeral environment spinning up at http://54.213.200.158:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[yousoph]

When using keyboard navigation to tab through on a dashboard, the highlight on the chart title in dashboards doesn't seem to be appearing for me

[eschutho]

/testenv up

[github-actions[bot]]

@eschutho Ephemeral environment spinning up at http://54.202.14.64:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[eschutho]

/testenv up

[github-actions[bot]]

@eschutho Ephemeral environment spinning up at http://52.35.108.27:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[eschutho]

/testenv up

[github-actions[bot]]

@eschutho Ephemeral environment spinning up at http://35.87.72.46:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kasiazjc]

@eschutho Ephemeral environment spinning up at http://35.87.72.46:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

I think this looks good! Thanks @eschutho 🙏

[rusackas]

This changes the default behavior of the Edit Chart link, from opening in the same window to a new one. This might open an old can of worms — is it intentional?

[eschutho]

This changes the default behavior of the Edit Chart link, from opening in the same window to a new one. This might open an old can of worms — is it intentional?

No, not intentional. Thanks for flagging that.

[eschutho]

/testenv up

[github-actions[bot]]

@eschutho Ephemeral environment spinning up at http://35.90.66.154:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

When I'm navigating the dropdown with arrows, the whole page scrolls with every click 🙁 And it looks like I can't navigate to Submenus

https://github.com/apache/superset/assets/15073128/9ec868f4-46c5-40bb-acdd-dab953baaeab

[eschutho]

When I'm navigating the dropdown with arrows, the whole page scrolls with every click 🙁 And it looks like I can't navigate to Submenus

Yeah, I didn't add the submenus yet. That's for a separate PR.

[github-actions[bot]]

Ephemeral environment shutdown and build artifacts deleted.