superset
superset copied to clipboard
fix(migration): Support non-alphanumeric passwords in alembic.
This commit modifies alembic's env.py
, so that it supports non-alphanumeric passwords.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ x] Has associated issue: Fixes #26029
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
57d61df
) 69.09% compared to head (626ea48
) 70.64%. Report is 362 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
superset/migrations/env.py | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #26094 +/- ##
==========================================
+ Coverage 69.09% 70.64% +1.54%
==========================================
Files 1940 1945 +5
Lines 75867 82222 +6355
Branches 8444 8444
==========================================
+ Hits 52423 58087 +5664
- Misses 21268 21959 +691
Partials 2176 2176
Flag | Coverage Δ | |
---|---|---|
hive | 54.20% <0.00%> (+0.51%) |
:arrow_up: |
mysql | 77.97% <0.00%> (-0.19%) |
:arrow_down: |
postgres | 79.36% <0.00%> (+1.10%) |
:arrow_up: |
presto | 54.24% <0.00%> (+0.60%) |
:arrow_up: |
python | 83.86% <0.00%> (+0.91%) |
:arrow_up: |
sqlite | 78.71% <0.00%> (+1.79%) |
:arrow_up: |
unit | 56.16% <0.00%> (+0.36%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hmm... title looks fine... but other CI tasks are stuck too. Closing/reopening to kick this. It might need a rebase, and @craig-rueda might want to take a fresh look.
@ramki88 would you mind running the pre-commit hooks on this so it can pass CI/linting?
@ramki88 would you mind running the pre-commit hooks on this so it can pass CI/linting?
Sure, I've ran it and rebased with master.
Running CI. Fingers crossed!
Hey! Do you have any news on this topic? :) Would be really helpful to have a working fix for special characters
I think the fact that some tests aren't running, and we have a weird (possibly unrelated) MySQL test error, indicates that some of these CI tasks have been fixed on master
but aren't being reflected here. A rebase of this branch/PR (again, I know, sorry...) might resolve that. CI has been a bit turbulent lately.
I think the fact that some tests aren't running, and we have a weird (possibly unrelated) MySQL test error, indicates that some of these CI tasks have been fixed on
master
but aren't being reflected here. A rebase of this branch/PR (again, I know, sorry...) might resolve that. CI has been a bit turbulent lately.
Sure, I have rebased with master https://github.com/apache/superset/pull/26094/commits/8fb2cae8fc8cbc36aca02ab2caf72b755663da4c