superset icon indicating copy to clipboard operation
superset copied to clipboard

Generated queries contain `LIMIT` even though `allow_limit_clause = False` in dbEngineSpec.

Open Afsalmc opened this issue 1 year ago • 1 comments

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Go to 'Sqllab'
  2. Click on 'SEE TABLE SCHEMA'
  3. Scroll down to any schema and click it to preview the table schema.
  4. Click the Copy select statement button near table name.
  5. In select query you can see LIMIT keyword.

Expected results

Generate query with TOP or anything other than LIMIT since allow_limit_clause is false.

Actual results

Query with LIMIT keyword.

Screenshots

image

Environment

(please complete the following information):

  • browser type and version:
  • superset version: 3.0.1
  • python version: 3.10
  • node.js version: v18.12.1

Checklist

Make sure to follow these steps before submitting your issue - thank you!`

  • [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x] I have reproduced the issue with at least the latest released version of superset.
  • [x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

Afsalmc avatar Nov 22 '23 09:11 Afsalmc

@michael-s-molina @betodealmeida May I know in the code where it is adding limit 100 ?

Afsalmc avatar Nov 25 '23 14:11 Afsalmc