superset icon indicating copy to clipboard operation
superset copied to clipboard

Thumbnails via Playwright Don't Work on some Dashboards

Open virgofx opened this issue 2 years ago • 3 comments

Screenshot

When using Playwright via feature flag.

image

Expected result (when not using playwright)

image

Description

It appears when using a custom background on a dashboard it covers the entire screenshot as shown above.

Custom CSS was applied as follows:

 /* changing the main dash background */
  .dashboard-content{
      background-color: green; --#452b5b;
  }

  /* changing the title bar background and text color */
  /* note that the title text looks goofy in edit mode */
  .header-with-actions {
    background-color: green; --#452b5b;
    color: white;
  }

  /* messing with the header tabs bar */
  /* this is a ridiculous selector... more classes or test attributes could help */
  .dashboard-header-container + div .dashboard-component.dashboard-component-tabs {
    background: green; --#452b5b;
  }

/cc @kgabryje

virgofx avatar Nov 10 '23 22:11 virgofx

@virgofx are you still facing this in Superset 3.1/4.0? @sadpandajoe do we test around custom CSS at all, out of curiosity? @kgabryje any Playwright theories here?

rusackas avatar Apr 18 '24 22:04 rusackas

I'll spin out a new cluster with latest tag with Playwright this/next week and let ya know.

virgofx avatar Apr 18 '24 22:04 virgofx

Confirmed the issue reported is still accurate with latest build apache/superset:68c77d6-py310.

image

virgofx avatar Apr 23 '24 23:04 virgofx