superset icon indicating copy to clipboard operation
superset copied to clipboard

Published 20 hours ago • verified publisher icon apache

fix(helm): disable istio on init-db Job

Open Cerebus opened this issue 1 year ago • 4 comments

SUMMARY

Adds a label to init-db job to disable istio sidecar injection.

TESTING INSTRUCTIONS

  1. Deploy Kubernetes
  2. Deploy Istio
  3. Create superset namespace
  4. Enable automatic sidecar injection
  5. Install superset

ADDITIONAL INFORMATION

  • [x] Has associated issue: closes #25798
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

Cerebus avatar Oct 30 '23 20:10 Cerebus

This will need a version bump and readme rebuild for CI to pass

craig-rueda avatar Oct 31 '23 13:10 craig-rueda

This will need a version bump and readme rebuild for CI to pass

Hope I did that right.

Cerebus avatar Oct 31 '23 14:10 Cerebus

Missing the helm chart bump

You want this as a feature bump (0.11.0) or a fix bump (0.10.16)?

Cerebus avatar Nov 16 '23 13:11 Cerebus

Hi @Cerebus - just checking in to see if you're planning to follow up on this one, or if @villebro thinks this is something we should "adopt." The related issue is getting stale, but I'll leave it open in hopes that this PR can get merged :)

rusackas avatar Apr 05 '24 20:04 rusackas

@Cerebus please rebase this PR - there seems to be lots of unrelated changes making it difficult to review the proposed changes.

villebro avatar Apr 07 '24 19:04 villebro